Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed order.shipping_lines.id to uint64 #288

Merged
merged 2 commits into from
May 15, 2024
Merged

Changed order.shipping_lines.id to uint64 #288

merged 2 commits into from
May 15, 2024

Conversation

roelofjan-elsinga
Copy link

@roelofjan-elsinga roelofjan-elsinga commented May 15, 2024 •
edited
Loading

The shipping_lines return their ID as an uint64, not a string. I've updated this in the fixtures as well.

oliver006
oliver006 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@oliver006 oliver006 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@oliver006 oliver006 merged commit c8f0c86 into bold-commerce:master May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver006 oliver006 oliver006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roelofjan-elsinga @oliver006