Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If form was not found, try again using a looser CSS selector #24

Merged
merged 1 commit into from
Jul 9, 2018
Merged

If form was not found, try again using a looser CSS selector #24

merged 1 commit into from
Jul 9, 2018

Conversation

peterjaap
Copy link
Contributor

Compatibility for Rubic_CleanCheckout. The order comment wasn't passed because the form wasn't found in the checkout.

@boldsidney
Copy link
Contributor

hi @peterjaap ,
Thank you for your pull request.

I had a quick look on an install with

  • "magento/product-community-edition": "2.2.3"
  • "boldcommerce/magento2-ordercomments": "^1.4"
  • "rubic/magento2-module-clean-checkout": "^2.0"
  • sample data

But i didnt realy discover any incompatibilities with the clean checkout extension, when using the old form selector. The comment was properly passed to the order.

Do i need certain settings to reproduce the issue that this pull request addresses?

@peterjaap
Copy link
Contributor Author

@boldsidney we show the order comment field below the payment methods, instead of per payment method. I just can't remember which settings that was..

@boldsidney
Copy link
Contributor

hi @peterjaap , I haven't found this particular setting you speak of, but seeing as this is an useful change for those that have moved the comment field, I'll merge it anyway.

@boldsidney boldsidney merged commit 1903856 into boldcommerce:master Jul 9, 2018
@peterjaap peterjaap deleted the cleancheckout-compat branch July 9, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants