Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ref to OrderComment::COMMENT_FIELD_NAME in InstallData, adminhtml spelling fix #30

Merged
merged 2 commits into from
Jan 14, 2019
Merged

added ref to OrderComment::COMMENT_FIELD_NAME in InstallData, adminhtml spelling fix #30

merged 2 commits into from
Jan 14, 2019

Conversation

PathToLife
Copy link

I liked how you used OrderComment::COMMENT_FIELD_NAME. So decided to put in in InstallData as well

PathToLife
PathToLife commented Dec 27, 2018
View reviewed changes
Copy link
Author

@PathToLife PathToLife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should merge this as well

@PathToLife PathToLife changed the title added ref to OrderComment::COMMENT_FIELD_NAME in InstallData added ref to OrderComment::COMMENT_FIELD_NAME in InstallData, adminhtml spelling fix Dec 27, 2018
@boldsidney boldsidney merged commit c985ed9 into boldcommerce:master Jan 14, 2019
@boldsidney
Copy link
Contributor

hi @PathToLife ,
Sorry for the delay and thanks for the changes. They have now been included in version 1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PathToLife @boldsidney