Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct field value depending on localization settings #1299

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Get correct field value depending on localization settings #1299

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1914ee1
Get correct field value depending on localization settings
I-Valchev Apr 15, 2020
32c3022
A bit more comments
I-Valchev Apr 15, 2020
f8d837d
Update templates/content/_fields.html.twig
bobdenotter Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion templates/content/_fields.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
aria-labelledby="{{ group|slug }}-tab">
{% for key, fielddefinition in record.definition.fields|filter(fielddefinition => fielddefinition.group == group) %}
{% if record.hasField(key) %}
{% set field = record.getField(key)|translated(currentlocale) %}
{% set field = record.getField(key) %}
{% if field.isTranslatable %}
{# If the field is translatable, we want the translated value in the current locale #}
{% set field = field|translated(currentlocale) %}
{% else %}
{# Otherwise, we want the value in the default locale, explicitly in case it is something else #}
{% set field = field|translated(field.defaultLocale) %}
{% endif %}
{% else %}
{% set field = field_factory(key, fielddefinition) %}
{% endif %}
Expand Down