Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require confirmation to delete collection item in editor #1343

Merged
merged 3 commits into from
May 1, 2020

Conversation

I-Valchev
Copy link
Member

No description provided.

@I-Valchev
Copy link
Member Author

Hmm... rather than doing this (which will be messy anyway), it may be more useful to create a button "Restore saved version" instead, as this will also work for any sort of changes made? What this would do is just reload the page, without saving. @bobdenotter

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green lights!

@bobdenotter bobdenotter merged commit eca2350 into master May 1, 2020
@bobdenotter bobdenotter deleted the feature/confirm-collection-item-delete branch May 1, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants