Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users extension prep #1618

Merged
merged 17 commits into from
Jul 13, 2020
Merged

Users extension prep #1618

merged 17 commits into from
Jul 13, 2020

Conversation

I-Valchev
Copy link
Member

This PR includes changes to Bolt for compatibility with a forthcoming users extension.

I-Valchev added 15 commits July 9, 2020 14:11
@I-Valchev
DetailControllerInterface, so that the DetailController can be extend…
c824f6a 
…ed inside extensions
@I-Valchev
Use UserStatus enum instead of disabled/enabled.
c293f75
@I-Valchev
Refactor DetailController moving renderSingle inside TwigAwareController
c4b3174
@I-Valchev
Make certain TwigAwareController methods public, so that extensions c…
5cff70b 
…an use them
@I-Valchev
Clean up the controllers from DetailController stuff
eb11e78
@I-Valchev
Detail controller interface so that extensions can override it but er…
4d362c5 
…ror controller still works
@I-Valchev
UserEvent to fetch dynamic roles
35d06d1
@I-Valchev
Add setter to UserEvent role options
57361e8
@I-Valchev
Rename user edit event
758e397
@I-Valchev
some more csfixes and security
9c520f2
@I-Valchev
Clean up services.yaml
26baeba
@I-Valchev
Update services.yaml
f418e01
@I-Valchev
Use correct UserStatus
24c7e7b
@I-Valchev
Make sure user exists when passing to listener
88f3eaa
@I-Valchev
When creating a new user, set the status
3d39aba
@I-Valchev I-Valchev changed the title [WIP] Users extension prep Users extension prep Jul 13, 2020
bobdenotter
bobdenotter approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoohoo! 👍

@bobdenotter bobdenotter merged commit abbfbd7 into master Jul 13, 2020
@bobdenotter bobdenotter deleted the enhancement/users branch July 13, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🧨 breaking change tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter