Make 'create user' a bit more robust #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @I-Valchev.. I'm merging this in, because i want to prep the release, but tomorrow i'd like to hear your opinion on the weirdness that's going on here.. I don't see how this could ever have worked correctly, and why it chose yesterday to start breaking on this. |
I-Valchev
reviewed
Nov 19, 2020
| @@ -151,6 +152,7 @@ Feature: Users & Permissions | |||
| And I should see "Suggested secure password" | |||
|
|
|||
| @javascript | |||
| @foo | |||
There was a problem hiding this comment.
@bobdenotter Oops... think we have to remove that! 🤪
|
@bobdenotter I don't know why it was breaking? Or what was breaking? It's strange that we need the default locale there, because the form is submitted and there the select already has a prepopulated option to begin with. Same for status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.