Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1.x] Fix behat tests #2282

Merged
merged 3 commits into from
Jan 6, 2021
Merged

[4.1.x] Fix behat tests #2282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec00231
Fix behat tests
I-Valchev Jan 5, 2021
a115c68
Update behavioural_tests.yaml
I-Valchev Jan 5, 2021
acff623
Fix embed size
I-Valchev Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/behavioural_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v1
with:
# test the lowest version, to make sure checks pass on it
php-version: ${{ matrix.php-version }}
coverage: none
with:
# test the lowest version, to make sure checks pass on it
php-version: ${{ matrix.php-version }}
coverage: none
- name: Install dependencies
run: |
sudo composer self-update -q
Expand Down Expand Up @@ -55,6 +55,7 @@ jobs:
fail-fast: false
matrix:
node-version: ['12.5']
php-version: ['7.2']
steps:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v1
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/edit_record_1.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ Feature: Edit record
And I wait for "fields[embed][title]" field value to change
Then the "fields[embed][title]" field should contain "Silversun Pickups - Nightlight (Official Video)"
And the "fields[embed][authorname]" field should contain "Silversun Pickups"
And the "fields[embed][width]" field should contain "480"
And the "fields[embed][height]" field should contain "270"
And the "fields[embed][width]" field should contain "200"
And the "fields[embed][height]" field should contain "113"

When I click ".editor__embed .remove"
# Add wait to make sure JS clears the fields before assert occurs
Expand Down