Allow search queries containing special characters (fix for #2427) #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format of the content in `bolt_field_translation`.
bobdenotter
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Hi @EmilePerron !
Maybe someday we'll have a full-fledged search, that works across different databases. For now, your fix seems fine. Thanks! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
This is a fix for the issue I described in #2427.
I added search term encoding & escaping to match the format of the content in
bolt_field_translation.There doesn't seem to be any tests for this repository/method, but I tested the change on a Bolt project with:
... and they all worked fine.
If there are tests set up for this and I just missed them somehow, just let me know and I'll take the appropriate steps.
Cheers!