Component Explorer Improvements + Speed Boost #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ountered with older buggy versions of lit-html directives
…er intro section for the component explorer UI; add pre-rendered HTML to help with initial page loading experience
… viewer accordion
…component + schema form sub-component; addresses performance and re-rendering issues encountered when only using Preact for handling the overall component rendering
|
⚡ PR built on Travis and deployed a now preview here:
|
…wo lines on the smallest screen sizes
|
Performance Test Comparing These Updates: Mobile: https://www.webpagetest.org/video/view.php?id=190107_156243b594a2bb3ee6eb96e06f289205ef33126c Desktop: https://www.webpagetest.org/video/view.php?id=190107_a42574deca0bd85d648e62002cbb18acb983a3be |
|
⚡ PR built on Travis and deployed a now preview here:
|
danielamorse
approved these changes
Jan 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-879?filter=-1
Summary
UI cleanup + overall improvements to the new component explorer component on the boltdesignsystem.com site.
Details
These updates should help speed up the initial and subsequent component being rendered + improves the accuracy of the component re-renders (via splitting apart the React JSON Schema Form UI into a Preact-specific component and decoupling this from the rendered component via Lit-HTML...)
Funny enough, no longer rendering this component preview in an iFrame helps a TON with the overall performance of this!
How to test