Generate schema for new added icons #1020
Conversation
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
There was a problem hiding this comment.
Awesome! Nice work @adam2661! There's just one small update I'd want to see added to this before this is good to go from me.
In addition to updating the <bolt-icon> schema file directly (really like that approach) -- could you also export that same array of icons as a JSON file to our data directory, similar to this called icons.bolt.json?
I want to make sure we're automatically exposing this data as JSON to make it super easy for Drupal to have an always up to date list of Bolt icons that are available. Better we take care of this now while we're at it.
…nto feature/generate-schema-for-new-added-icons # Conflicts: # docs-site/.incache # yarn.lock
|
@sghoweri i just update the PR and file that you mention is generated in the data directory. |
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
|
@sghoweri i don't know why smoke test and liniting has this error: |
|
⚡ PR built on Travis and deployed a now preview here:
|
…er to @bolt/build-tools; added updates to still resolve the right path to @bolt/components-icons, auto-disable the build task if the icons package isn't present, and added auto-regeneration via the watch task.
…om the original @bolt/components-icons package
…d and watch tasks to the build tools' task collection
|
⚡ PR built on Travis and deployed a now preview here:
|
Jira
http://vjira2:8080/browse/BDS-88
Summary
Update bolt-icons component by giving a possibility to generate the updated schema in bolt-icon component.
Details
Small changes in bolt-icons component and add
js-yamlpackage to dependencies.How to test
Run this code locally. Add new svg icon to
packages/components/bolt-icons/src/svgs. Run this code i command line in the project root:npm run setup:fullthen run this command:npm start. Rundocs-sitein the browser. Go tocomponents > Icon > Icon Name Variationsand check if new icon is added to it. Additionally, check if you have generated a file in:www/build/datacalledicons.bolt.json.