Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightwatch checks reports and CI/Checks improvments #1026

Merged
merged 132 commits into from
Jan 22, 2019
Merged

nightwatch checks reports and CI/Checks improvments #1026

merged 132 commits into from
Jan 22, 2019

Conversation

EvanLovely
Copy link
Contributor

@EvanLovely EvanLovely commented Jan 10, 2019 •
edited
Loading

Stuff to do

  • (Joe) consolidate bolt-site.e2e.js and pattern-lab.e2e.js into globals.e2e.js
  • (Evan) refactor API calls to Sauce Labs
  • (Evan) make execAndReport check run function

Blocked

  • (Joe) theme output of Nightwatch reports
  • (Joe) create lint check run using execAndReport

bolt-bot and others added 30 commits November 28, 2018 20:54
@bolt-bot
chore: adding nightwatch screenshots
e56d4d0
@bolt-bot
feat: initial nightwatch.js refactor work; adding support for split t…
a8cf89f 
…ests + different local and remote testing setups in the package.json file
@bolt-bot
Merge branch 'master' of https://github.com/bolt-design-system/bolt
1978e81
@bolt-bot
Merge branch 'master' into feature/nightwatch-testing
f9a229f
@bolt-bot
fix: disable mandatory e2e testing on local push for now
2a6ace7
@bolt-bot
fix: fix prettier issues
5ed26db
@bolt-bot
fix: fix typo
70d49c0
@bolt-bot
fix: removing old code
3f6c861
@EvanLovely
feat: add get-latest-deploy script
1817107
@EvanLovely
chore: adjust ci paths
45ec6bb
@joekarasek
fix: add error catcher to bash getLatestDeploy
a0935cf
@EvanLovely
chore: fix var captilization and add a few more checks
b4ab115
@EvanLovely
chore: setup early response in CI
80a6289
@EvanLovely
chore: CI inspect
b48418d
@joekarasek
Merge branch 'master' into feature/nightwatch-testing - accepting mas…
1307fcc 
…ter version of package.json wholesale
@joekarasek
chore: manually adding package.json changes from this branch back in
3e75324
@joekarasek
chore: ci basic nightwatch test
43c11e3
@joekarasek
chore: add yarn install to nightwatch test
980faab
@joekarasek
fix: yarn install required packages in travis build
a0dadb0
@joekarasek
testing
cbbf282
@joekarasek
update path filter
3c200a2
@joekarasek
limit to chrome webdriver
0d85ba9
@joekarasek
update chromedriver package to latest
20d5757
@joekarasek
bump chrome driver back to older version
319caf1
@joekarasek
attempted fix for chrome hangup
fb405bc
@joekarasek
bump version of chrome and chromedriver
1946c47
@joekarasek
up verbosity
8cf727e
@EvanLovely
chore: disable selenium server in nightwatch
7200818
@EvanLovely
fix: nightwatch tearDown => afterEach
d9fd395
@EvanLovely
chore: nightwatch tweak
58b985f
@EvanLovely
Copy link
Contributor Author

@sghoweri
Copy link
Contributor

@EvanLovely @joekarasek - nice work!!

What's left on this before we can review and get this merged in?

@EvanLovely EvanLovely changed the title WIP nightwatch checks reports nightwatch checks reports and CI/Checks improvments Jan 15, 2019
@EvanLovely
Copy link
Contributor Author

@sghoweri This is all set to go! Tons of goodness in here; please, please squash this commit!

@sghoweri
Copy link
Contributor

@adam2661 head’s up!

You are REALLY going to want to use these updates as a starting point for the upcoming Nightwatch task on the board — @EvanLovely and @joekarasek crushed it with these improvements!!

@sghoweri sghoweri mentioned this pull request Jan 15, 2019
Closed
@adamszalapski
Copy link
Collaborator

Thanks, @sghoweri.

@EvanLovely EvanLovely mentioned this pull request Jan 15, 2019
Merged
3 tasks
sghoweri
sghoweri approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@sghoweri sghoweri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way we could have done this work ourselves in such a short amount of time -- @EvanLovely and @joekarasek THANK YOU both so much for your help on this! 🎉🍻

@sghoweri sghoweri mentioned this pull request Jan 22, 2019
Merged
@sghoweri sghoweri merged commit 32d8a92 into master Jan 22, 2019
This was referenced Feb 1, 2019
Closed
Closed
@sghoweri sghoweri mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sghoweri sghoweri sghoweri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EvanLovely @sghoweri @adamszalapski @bolt-bot @joekarasek