WIP: Blockquote Refactor Suggestions #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text component's Twig files
…ass-based equivalents
…r advantage of slots
|
⚡ PR built on Travis and deployed a now preview here:
|
…ge when JS is loading
…tern Lab-specific pages
… title's Twig to use a cite tag to match JS template
…hen child node mutations are observed
|
⚡ PR built on Travis and deployed a now preview here:
|
|
Thanks @sghoweri! Major improvements here. I've merged in the changes. Now, going to review more locally and re-submit my original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
(Enter a link to the Jira issue this PR applies to, if any)
Summary
(Enter a one-line summary of the changes in this PR. This will be included in the release notes)
Details
(Explain the changes in enough detail fo reviewers to understand. Raise any questions for reviewers to consider.)
How to test
(List clear steps to test that the changes are working)