Fix Missing Build Tools Dependency + Postinstall Fix

[sghoweri]

JIRA

N/A

Summary

Addresses two dependency-related items flagged with the initial Bolt v2.3.0 release candidate.

• Testing Instructions

Note: this will also be included in the next v2.3.0 release candidate: v2.3.0-rc.1

Description

1. Adds the missing Twig Renderer dependency to @bolt/build-tools
2. Updates the way PHP-related dependencies are installed. This update removes using the NPM postinstall script so certain dependencies aren’t attempted to be auto-installed in Drupal or any downstream consumer — only in the Bolt monorepo automatically via the Lerna exec command.

Testing Instructions

• Verify everything installs and compiled as expected in Bolt
• Verify these updates sufficiently address the initial issues flagged in Drupal. @remydenton any thoughts on how we can cleanly double check this without having to do another full release?

[remydenton]

🤔 I can't think of a good way to fully test without doing any publishing (is there a way to pull in npm packages that aren't published at all, such as by specifying a local path to a package? I don't know of one).

We could potentially do some canary releases, though I'm not sure that would prevent any more headaches than just doing a point release and hoping for the best...

[sghoweri]

🤔 I can't think of a good way to fully test without doing any publishing (is there a way to pull in npm packages that aren't published at all, such as by specifying a local path to a package? I don't know of one).

We could potentially do some canary releases, though I'm not sure that would prevent any more headaches than just doing a point release and hoping for the best...

@remydenton

Yeah I was considering either us doing a canary release with just the packages updated here OR mentioning that you could reference NPM packages locally if you have the repo checked out (ex. check out https://github.com/bolt-design-system/bolt/blob/master/docs-site/package.json#L61).

I think the tricky part of this is that the changes involve dependencies of dependencies which, while you could technically try to wire up locally, would quickly get out of sync with the actual changes expected to get published.

I'm leaning a little bit more towards doing a canary release on this but could be swayed if @margoromo or @danielamorse had any thoughts on this

[danielamorse]

Approved. Did a fresh install locally, ran start and build, and all worked as expected.

@sghoweri not sure I can add much to the canary vs point release conversation. I like the idea of a canary release better so that we don't potentially have another broken release in the wild, but I don't actually know how we make a Bolt canary release. I've only seen the point release process.

[remydenton]

Though I'm not able to actually test in Drupal without a canary release or similar, this all makes sense from a code review perspective. It should, theoretically, resolve both the issues I saw in Drupal.