Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tool: IE11-only SCSS mixin #1055

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

mikemai2awesome
Copy link
Collaborator

Jira

N/A

Summary

Adds a SCSS mixin for Bolt devs to define IE11 CSS.

Details

Created bolt-ie11-only mixin under tools in the core. This will make it easier every time we need to write CSS that only applies to IE11.

How to test

  1. Run the branch locally.
  2. Add the following test code to any component CSS to target that component:
@include bolt-ie11-only {
  * {
    background-color: red !important;
  }
}
  1. Make sure whatever you targeted turned to red.

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the idea of this BUT I want to make sure we're only using this mixin when we physically can't target based on feature support of some specific CSS property or style something via progressive enhancement (ie. no @support styles initially + @support styles on top of that)

@danielamorse danielamorse merged commit 786ed53 into master Jan 24, 2019
This was referenced Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants