Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom solution: Careers homepage background video #1056

Merged
merged 16 commits into from
Feb 21, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Jan 25, 2019

Jira

http://vjira2:8080/browse/BDS-1013

Summary

Created a custom solution (non-Bolt) to insert an autoplaying video into a band.

Details

  1. Custom CSS is written inline on the page markup with the <style> tag.
  2. The custom video is added to the band background through a block.
  3. Variables are set up for all the editable fields.

How to test

  1. Run the branch locally.
  2. Check the mockup page: http://localhost:3000/pattern-lab/patterns/04-pages-50-d8-careers-00-careers-homepage/04-pages-50-d8-careers-00-careers-homepage.html

Limitations of this custom solution

  1. Background video must be square to accommodate all screen sizes and the dynamic height and width of the band.
  2. Background video should only be served as a decoration, expect it to be cropped anywhere within its square size.
  3. Background video disappears when the browser size falls below 800px, this is where the white space is diminishing to a point that makes the height of the band longer than width of the band, which could result in the video not covering the entire background.
  4. Background video poster must be provided as a fallback for when video disappears.

@mikemai2awesome mikemai2awesome changed the title POC Background Video w/ Parallax Custom solution: Careers homepage background video Feb 6, 2019
Copy link
Collaborator

@remydenton remydenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works as expected. Nice work @mikemai2awesome!

@sghoweri sghoweri mentioned this pull request Feb 21, 2019
@sghoweri sghoweri merged commit 76aefc9 into master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants