Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing / Deployment-related DevOps Fixes #1068

Merged
merged 21 commits into from
Feb 1, 2019
Merged

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Jan 31, 2019

Jira

http://vjira2:8080/browse/BDS-1024

Summary

Implements several housekeeping updates, improvements and fixes to our DevOps CI / CD process to continue to improve how smooth we ship Bolt releases. There's still more work to be done but this should at least help tackle some of the more pressing issues.

Details

  • Adds logic to auto-regenerate the Bolt version data used to populate the version select / dropdown menu on the boltdesignsystem.com site
    • Also adds logic to the after-publish script to regenerate and include this updated data after a release
  • Updates our post-publish logic + root lerna.json config to try and fix the tagged version mis-match issues. This issue has been causing Lerna to think every single package in Bolt has been changed since the previous release (vs only a handful at times)
  • Splits apart and simplifies our deployment logic to handle the initial now.sh deployment separately from the now.sh aliasing. This should help avoid some major problems that can occur if a Travis test fails AFTER a particular build has been pushed live to a specific branch or git tag alias.
  • Updates the Github Checks API logic to try and remove the empty browser screenshots (the very first screenshot in the series taken)
  • Updates the logic that handles grabbing the latest now.sh deployment URL (based on codebase's Git Hash) to handle situations where the results returned don't always match up 1:1 with the local git SHA (partial match) + sorting the results to be in the correct order

How to test

?
Publish a few extra releases? This is super tricky to fully test without publishing an actual release or release candidate in order to make sure we didn't miss anything.

Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sghoweri, as you mentioned, there's not really any way for me to test this without making more releases. The changes outlined make sense to me, and I looked through the code and there's nothing there that concerns me. If the most recent release worked as expected with these changes, then I approve.

@sghoweri sghoweri mentioned this pull request Feb 1, 2019
@sghoweri sghoweri merged commit 040fa7e into master Feb 1, 2019
@sghoweri sghoweri deleted the fix/devops-fixes branch February 1, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants