Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightwatch.js run local tests #1077

Merged
merged 26 commits into from
Feb 21, 2019
Merged

Nightwatch.js run local tests #1077

merged 26 commits into from
Feb 21, 2019

Conversation

adamszalapski
Copy link
Collaborator

@adamszalapski adamszalapski commented Feb 7, 2019

Jira

http://vjira2:8080/browse/BDS-15

Summary

This is the first phase of creating a test for lazyloaded images.

Details

Give the possibility to run Nightwatch test on the local environment.

How to test

Run this code on local env. Remove node_modules and www folders. Then run npm run setup. After this command please try to run a test by running: npm run test:e2e:quick-local if you want to run full test please run this command npm run test:e2e:full-local.
Because we use Mac machine we can't run IE11 and Edge tests locally.
NOTE: You must have installed Chome to run a Quick test.
NOTE 2: You must have installed Firefox and Safari to run Full tests.
NOTE 3: To run Full test correctly you must in Safari enable the developer menu and enable the Allow Remote Automation option.

@adamszalapski adamszalapski removed the WIP label Feb 8, 2019
@adamszalapski
Copy link
Collaborator Author

All test is passed, because in firefox and internet explorer 11 movetoElement() is not supported i must change it to only check if the c-bolt-image-zoom__overlay-icon class is present on the page.

Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @adamszalapski! I’m good with these updates — @danielamorse or @remydenton any feedback?

@adamszalapski
Copy link
Collaborator Author

I updated test for bolt-video module

@sghoweri
Copy link
Contributor

There’s a couple small things I’d like to see us update as a fast follow to this but that shouldn’t block getting this merged down to master:

  1. Update our docs on testing to include info about Nightwatch

  2. Update our getting started docs and add a note about optionally needing to install the Java SDK if when running local Nightwatch tests / running Selenium server

  3. Come up with a way to auto spin up our dev server + kick off Nightwatch tests AND automatically use the correct dev server port. I made a bit of progress looking into this however there’s still some tricky config / emitted event work left wiring this all up 🙂

@sghoweri sghoweri mentioned this pull request Feb 20, 2019
@sghoweri sghoweri merged commit e6fc4d4 into master Feb 21, 2019
@sghoweri sghoweri deleted the feature/nightwatch-local-tests branch February 21, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants