Band Component Refactor (Band Demo Cleanup from #1010) #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Band component Twig namespace + misc cleanup
…e full @bolt-components-band twig namespace
sghoweri
changed the title
sghoweri
added a commit
that referenced
this pull request
Feb 21, 2019
remydenton
approved these changes
Mar 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikemai2awesome - this is another PR subset of the full #1010 PR -- this one only includes the Twig-specific updates that didn't require any Band component-specific updates (so before the schema changed).
This helps simplify what changes this PR involves + allows us to only PR the changes involved from #1010 (minus #1088) to make things a lot more easily reviewable + more easily understand if an update is a breaking vs non-breaking change. Only one more Band-specific PR after this one!
Jira
http://vjira2:8080/browse/BDS-828
Summary
Updates all Band components being used in Bolt (docs site, demos, etc) to use the full Twig namespace include path. Subset of work involved to refactor the Bolt Band component.
How to test