Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt-card documentation and testing #1094

Merged
merged 5 commits into from
Mar 6, 2019

Conversation

adamszalapski
Copy link
Collaborator

Jira

http://vjira2:8080/browse/BDS-956

Summary

Adding documentation and tests for bolt-card component

How to test

Check if all test pass. Check testing documentation.

Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamszalapski, I ran the tests locally and reviewed the code. All looked good 👍

Sorry to nitpick, but I made some suggestions for the testing steps, mostly just re-phrasing lines that were a little unclear to me at first. I pushed the edits to this branch: feature/bolt-card-documentation-and-testing--edits. Feel free to pull it into your branch if this works for you.

@adamszalapski
Copy link
Collaborator Author

@adamszalapski, I ran the tests locally and reviewed the code. All looked good 👍

Sorry to nitpick, but I made some suggestions for the testing steps, mostly just re-phrasing lines that were a little unclear to me at first. I pushed the edits to this branch: feature/bolt-card-documentation-and-testing--edits. Feel free to pull it into your branch if this works for you.

@danielamorse thank you for update my testing steps. Your updated testing steps are better than mine. 👍 Definitely, I will put all the changes to my branch.

@sghoweri sghoweri mentioned this pull request Mar 6, 2019
@sghoweri sghoweri merged commit af4cad8 into master Mar 6, 2019
@sghoweri sghoweri deleted the feature/bolt-card-documentation-and-testing branch March 6, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants