Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Travis Config to Fix Silent Unit / Lint Test Failures #1103

Merged
merged 5 commits into from
Mar 11, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Mar 6, 2019

Jira

http://vjira2:8080/browse/BDS-1048 and http://vjira2:8080/browse/BDS-1049

Summary

Updates how the original Travis + Github Checks API integration was handling our Linting and Jest unit tests. This update should help ensure any errors encountered during the Travis build clearly fail (vs silently failing unless looking at the Github Checks API status).

Details

  • Splits apart the Travis CI jobs that test for code quality (lint tests) vs code functionality (unit tests)
  • Adds caching to Travis jobs (hopefully speeding up the build times on Travis at least a little)

How to test

  • Confirm all stages of the Travis CI build pass

@sghoweri sghoweri added the bug label Mar 6, 2019
@sghoweri sghoweri added this to the v2.4.0 milestone Mar 6, 2019
@sghoweri sghoweri requested a review from danielamorse March 7, 2019 12:39
@sghoweri sghoweri mentioned this pull request Mar 11, 2019
@sghoweri sghoweri merged commit 1e469ee into master Mar 11, 2019
@sghoweri sghoweri deleted the fix/split-travis-unit-and-link-tests branch March 11, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants