fix: Avoid auto-escaping in image component #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remydenton
force-pushed
the
hotfix/WWWD-3263-prevent-autoescaping
branch
from
76eb4fa to
b27b15f
Compare
|
@danielamorse I'm going to get this merged into the v2.x branch so I can cut a v2.3.1 release however I wanted to make sure you get a chance to look through this separately since you've been neck deep in the image component refactor + the fact that this issue could still happen again in other places... 😅 |
sghoweri
approved these changes
Apr 17, 2019
…event-autoescaping
…ing the php7.2 install that should no longer be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/WWWD-3263
Summary
Prevents autoescaping of image contents.
Details
See http://vjira2:8080/browse/WWWD-3263 for the backstory.
How to test
Copy the changes made in this PR to
node_modules/@bolt/components-image/src/image.twigin the pega.com Drupal theme. Before these updates, images will be missing; after these updates, they'll be restored.