Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Prevent Now.sh Deploy Alias Failures #1122

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Hotfix: Prevent Now.sh Deploy Alias Failures #1122

merged 2 commits into from
Mar 19, 2019

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Mar 19, 2019 •
edited
Loading

Jira

http://vjira2:8080/browse/BDS-1186

Summary

Updates the logic for our now.sh deploy URL aliases to ensure the alias name (based off of the name of the Git branch) doesn't exceed 63 characters long and cause the now.sh deployment to fail as seen on #1120 and https://github.com/bolt-design-system/bolt/pull/1120/checks?check_run_id=80710490

Details

  • Slightly refactors the deploy JS logic so the function that formats the URL is more easily testable
  • Updates the logic to truncate URL aliases that would be 62 characters in length or longer
  • Adds a few Jest tests to make sure the branch name and URL alias logic are working as expected

How to test

  • Confirm the URL alias for this branch is properly truncated
  • Confirm the tests for this all pass

@sghoweri sghoweri requested a review from danielamorse March 19, 2019 15:43
@sghoweri sghoweri added the bug label Mar 19, 2019
danielamorse
danielamorse approved these changes Mar 19, 2019
View reviewed changes
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests locally and checked the new URL alias, all working as expected. Approved 👍

@sghoweri sghoweri mentioned this pull request Mar 19, 2019
Closed
@sghoweri sghoweri merged commit 9ab1ebc into master Mar 19, 2019
@sghoweri sghoweri deleted the fix/limit-the-absolute-maximum-length-of-our-super-long-now-alias-urls branch March 19, 2019 15:55
@sghoweri sghoweri mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielamorse danielamorse danielamorse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sghoweri @danielamorse