Share | QA | Testing and docs #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamszalapski
approved these changes
Mar 26, 2019
There was a problem hiding this comment.
Looks good on my end. Good work @mikemai2awesome
Errors on build are not related with your task:
|
Thanks man. I was confused about the build error. I couldn't figure it out. |
danielamorse
requested changes
Apr 1, 2019
There was a problem hiding this comment.
@mikemai2awesome left two inline comments. Otherwise, this is all looking good. Tests are passing locally 👍
danielamorse
approved these changes
Apr 2, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-958
Summary
Added tests for share component.
Details
share.jsin the tests folder now contains tests for all props.testing.mdnow has detailed instructions on manual testing.How to test
Run the branch locally and read through the testing javascript and markdown.