Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card/Video Thumbnail Update #2480

Merged
merged 5 commits into from
Aug 17, 2022
Merged

Card/Video Thumbnail Update #2480

merged 5 commits into from
Aug 17, 2022

Conversation

colbytcook
Copy link
Contributor

@colbytcook colbytcook commented Apr 15, 2022

Summary

Updated the card video demos to leverage the Video Thumbnail

Details

  • Added examples of the card using the Video Thumbnail component to play videos
  • Added in a z-index fallback for passing in a video thumbnail as media.content
  • The Brightcove JavaScript in the pega_bolt_video module will have to be updated with the latest in the docs-site/src/custom-brightcove.js file.

How to test

  • Pull down this branch
  • Navigate to the Card with Video demo page
  • Review the functionality on the individual cards

Release Notes

  • The Brightcove JavaSCript have slightly changed to accomidate the

… for passing in a video thumbnail as content
@colbytcook colbytcook changed the title [DO NOT MERGE] Card Video/Video Thumbnail \Update [DO NOT MERGE] Card/Video Thumbnail Update Apr 15, 2022
@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Apr 15, 2022
@colbytcook colbytcook temporarily deployed to feature/card-video-update--branch-preview April 15, 2022 20:16 Inactive
… demo to show examples of the video thumbnial functionality
@colbytcook colbytcook changed the title [DO NOT MERGE] Card/Video Thumbnail Update Card/Video Thumbnail Update Apr 18, 2022
@colbytcook colbytcook temporarily deployed to feature/card-video-update--branch-preview April 18, 2022 13:35 Inactive
Copy link
Collaborator

@danielamorse danielamorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Is there a reason you didn't tack the new z-index rule onto the end here? Otherwise, approved 👍

@colbytcook colbytcook temporarily deployed to feature/card-video-update--branch-preview August 16, 2022 15:17 Inactive
@colbytcook colbytcook temporarily deployed to feature/card-video-update--branch-preview August 16, 2022 18:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants