-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card/Video Thumbnail Update #2480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for passing in a video thumbnail as content
colbytcook
changed the title
[DO NOT MERGE] Card Video/Video Thumbnail \Update
[DO NOT MERGE] Card/Video Thumbnail Update
Apr 15, 2022
github-actions
bot
added
the
type: feature
List this PR in the 'Features' section of the release notes.
label
Apr 15, 2022
colbytcook
temporarily deployed
to
feature/card-video-update--branch-preview
April 15, 2022 20:16
Inactive
… demo to show examples of the video thumbnial functionality
colbytcook
changed the title
[DO NOT MERGE] Card/Video Thumbnail Update
Card/Video Thumbnail Update
Apr 18, 2022
colbytcook
temporarily deployed
to
feature/card-video-update--branch-preview
April 18, 2022 13:35
Inactive
danielamorse
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Is there a reason you didn't tack the new z-index rule onto the end here? Otherwise, approved 👍
cjwhitedev
approved these changes
Jun 28, 2022
colbytcook
temporarily deployed
to
feature/card-video-update--branch-preview
August 16, 2022 15:17
Inactive
colbytcook
temporarily deployed
to
feature/card-video-update--branch-preview
August 16, 2022 18:22
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the card video demos to leverage the Video Thumbnail
Details
media.content
pega_bolt_video
module will have to be updated with the latest in thedocs-site/src/custom-brightcove.js
file.How to test
Release Notes