DS-837 animate on scroll #2542
Merged
DS-837 animate on scroll #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 6, 2022 16:15
github-actions
bot
added
the
type: feature
…o feature/DS-837-Animate-On-Scroll-TEST-DEMO
danielamorse
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
@MarcinMr looks and works great.
FYI @andrewmriv and @remydenton (re: layout builder), animations will now start when an element is in the viewport rather than on load. If an element is in the viewport on load, it will animate immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://pegadigitalit.atlassian.net/browse/DS-837
Summary
JS triggers animations on elements when they come within the viewport.
Details
How to test
Pull the branch. Go to the Test Folder with examples of animations. Confirm that elements appear when visible in the viewport and when scrolling. Check the cascade and no-cascade behavior.
Release notes
The animation toolset is updated. Elements appear not only on the load event but they are observed. If they are on the viewport area the animation triggers.