Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-876 Article Element Word Wrap #2572

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

colbytcook
Copy link
Contributor

@colbytcook colbytcook commented Nov 15, 2022

Jira

https://pegadigitalit.atlassian.net/browse/DS-876

Summary

Long links shouldn't overflow parent containers

Details

  • The article.scss was updated on a tag withoverflow-wrap: break-word
  • A test page /pattern-lab/?p=viewall-tests-article was added to check the behavior of native HTML links and e-bolt-links inside e-bolt-article

How to test

Pull the branch. Go to the test page and confirm that long links wrap to another line if there's not enough space.

Release notes

Long links within an article (e-bolt-article) wrap if there's no space enough

@github-actions github-actions bot added the type: feature List this PR in the 'Features' section of the release notes. label Nov 15, 2022
@colbytcook colbytcook requested a review from MarcinMr November 15, 2022 13:52
@colbytcook
Copy link
Contributor Author

@MarcinMr I recreated the pull request because i think the hotfix branch path might have functionality tied to it (not sure but better safe than sorry).

@colbytcook colbytcook changed the title DS-876: update css + test article page DS-876 Article Element Word Wrap Nov 15, 2022
@colbytcook colbytcook requested a deployment to feature/DS-876-Article-Element-Word-Wrap--b37b737--commit-preview November 15, 2022 13:58 In progress
@colbytcook colbytcook merged commit 928e923 into master Nov 15, 2022
@colbytcook colbytcook deleted the feature/DS-876-Article-Element-Word-Wrap branch November 15, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature List this PR in the 'Features' section of the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants