Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for css class names with escaped characters #410

Merged
merged 3 commits into from
Feb 7, 2018

Conversation

EvanLovely
Copy link
Contributor

OK, this should fix the situation where css classes like .u-hide\@large get turned into .u-hide-large until the bug in css-loader can get fixed. /cc @sghoweri

Jake, can you check to see if this fixes the issue, then merge if it does?

@EvanLovely
Copy link
Contributor Author

EvanLovely commented Feb 7, 2018

Well, crap; getting this build error:

-theAtSymbol- is the temp string I was transforming it to and from.

Error: /home/travis/build/bolt-design-system/bolt/packages/global/styles/index.scss
Module build failed: ModuleBuildError: Module build failed: Unknown word (1:1)
> 1 | -theAtSymbol-charset "UTF-8";
    | ^
  2 | @font-face {
  3 |   font-family: OpenSansSubset;
  4 |   src: url(/fonts/opensans-subset.woff2) format("woff2"),url(/fonts/opensans-subset.woff) format("woff");

My initial tests were just on my small use case, not on the whole thing.

@EvanLovely
Copy link
Contributor Author

I've done some more research on the core issue and posted some findings in comments there. Also, I've found that disabling CSS Modules with modules: false also gets the behavior we want w/o this workaround. Are we using them?

@sghoweri sghoweri merged commit 7fedff6 into epic/refactor Feb 7, 2018
@sghoweri sghoweri deleted the feature/escaped-css-class-fix branch February 7, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants