Restore anchor click default behavior, which is required under certain conditions. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
⚡ Sauce Labs Test for chrome Passed!
Test Details
|
⚡ Sauce Labs Test for internet explorer Passed!
Test Details
|
sghoweri
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
@charginghawk - whoops - didn't see this preventDefault in here in the original PR! Good catch!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "preventDefault" to anchor link clicks broke the mobile experience for search facets, which depended on targeting specific fragments to effect certain styles. We use the "fragment targeting as js substitute" approach elsewhere on occasion (the pegaworld static menu, for example), so this has to be removed.
It was added to fix a minor flashing issue using anchor links in IE11, and we'll have to address that in a future PR.