Fix schema validation for sticky. #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghoweri
approved these changes
Aug 30, 2018
There was a problem hiding this comment.
Still waiting on Travis to give the green light but this checks out locally when testing this out in PL. Thanks @charginghawk!
|
⚡ PR built on Travis and deployed a now preview here:
|
⚡ Sauce Labs Test for chrome Passed!
Test Details
|
⚡ Sauce Labs Test for internet explorer Passed!
Test Details
|
⚡ Sauce Labs Test for chrome Passed!
Test Details
|
⚡ Sauce Labs Test for internet explorer Passed!
Test Details
|
remydenton
approved these changes
Aug 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The wrong schema here will throw a 500 error when loading sticky with twig_debug enabled. This fixes it.
How to test
Enabled twig_debug. View a page with the sticky component. It doesn't return a 500 error.