-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Lab UIKit Bug Fixes #903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in IE 11 + tweak the breakpoint when the Search component's font size reduces
…urved / notched displays (ex. the iPhone XS Max)
…y to address core UI issues with previous approach to handling the iframe content height
…less hacks required
… class vs inline style
⚡ PR built on Travis and deployed a now preview here:
|
… the UI for notched devices
⚡ PR built on Travis and deployed a now preview here:
|
…r layout is used — fixes issue with a slight overflow when resizing the PL iframe to full and the sidebar layout is used
⚡ PR built on Travis and deployed a now preview here:
|
mikemai2awesome
approved these changes
Oct 9, 2018
This was referenced Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Misc bug fixes + cross-browser related updates to Pattern Lab's UI
Before
After
Details
In particular, this PR:
Testing Instructions
Compare Pattern Lab's UI that's currently live with the updates from this branch -- especially on Safari and on mobile devices!