Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct button text and icon alignment #920

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

mikemai2awesome
Copy link
Collaborator

@mikemai2awesome mikemai2awesome commented Oct 18, 2018

Jira

N/A

Summary

Fixes a bug where bolt-button's align right is not displaying correctly.

Details

justify-content: start and justify-content: end are not working as intended. I've updated it to text-align: start and text-align: end with left and right fallback. That is working as intended now.

How to test

Pull down and run the branch locally, navigate in Pattern Lab to the button alignment demos, make sure all alignments are displayed correctly.

@bolt-bot
Copy link
Collaborator

⚡ PR built on Travis and deployed a now preview here:

@remydenton remydenton mentioned this pull request Oct 19, 2018
@sghoweri
Copy link
Contributor

Thanks @mikemai2awesome!

@sghoweri sghoweri merged commit d9163bc into master Oct 19, 2018
@sghoweri sghoweri deleted the fix/bolt-button-alignment branch October 19, 2018 11:24
@sghoweri sghoweri mentioned this pull request Oct 23, 2018
This was referenced Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants