Bug: Fix Button JS Rendered Event Emitted + Update Button JS Demo

[sghoweri]

Jira

http://vjira2:8080/browse/BDS-728

Details

Fixes the Bolt button component's JS logic so the ready and rendered JavaScript events —recently added to the globally shared Bolt base component in v2.x when a component renders initially + re-renders, respectfully— fires as expected.

Note: a recent update made to improve the cross-browser rendering of dynamically injected buttons caused this event to stop working as expected (forgot to call super.rendered(), however it's worth mentioning that given the virtually undocumented nature of this update and how the how this feature was only just recently added, it's incredibly unlikely this update was getting used downstream just yet.

For reference, these events were added in the v2.x release as a possible new pattern to help with consistently binding / rebinding 3rd party JavaScript to a Bolt component in a number of different use cases and situations:

• Binding to a component that hasn't yet finished rendering (either based on the order JavaScript runs and/or if the component is async loaded)
• Binding to a component that renders differently based on browser support (natively supporting Shadow DOM vs non-Shadow DOM rendering)
• Binding to a component that automatically renders differently based on the context it's getting used (ex. components used in forms automatically never render to the Shadow DOM since Bolt v1.x)
• Binding to a component which, based on data, state, DOM mutations, and lifecycle event changes, re-renders

How to test

• Check out the existing button JS demo in Pattern Lab and confirm the console logged event + theme toggle work as expected.

CC @charginghawk and @krlucas

[bolt-bot]

⚡ PR built on Travis and deployed a now preview here:

• Branch link: https://hotfix-fix-button-JS-event-demo.boltdesignsystem.com
• Permalink: https://boltdesignsystem-qariadgqtm.now.sh

• Commit built: 69bc8be
• Travis build