Add quick cache buster to Bolt docs site #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
remydenton
approved these changes
Nov 7, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
N/A
Summary
Adds a quick cache buster query string to the Bolt docs site head and footer’s main CSS and JS bundles.
Details
Quick workaround to the now.sh cache not always getting cleared in certain situations — namely when aliasing an existing deployment (like taking the existing deployment that’s running on the master.boltdesignsystem.com URL alias) and remapping it to another domain (like the live boltdesignsystem.com site).
Screenshots below show some of the old CSS showing up in the new version selector UI (before manually clearing the browser cache):
Note: we already deal with cache busting hashes in async loaded bundles — this is specifically dealing with cache busting the main entry file loaded till we get a more advanced Webpack solution wired up for this.
How to test
Confirm docs site JS and CSS loading as expected.