Fix: bolt-list inset prop twig logic #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
sghoweri
approved these changes
Nov 20, 2018
remydenton
reviewed
Nov 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
N/A
Summary
Fixes an issue with the bolt-list's
insetprop not rendering correctly.Details
The twig logic for the boolean
insetprop was not written correctly. It has been updated with our latest convention on how to handle boolean values.How to test
Run the branch locally and navigate to the bolt-list's inset demo pages, make sure the spacing is correct, and the class
.c-bolt-list--insetis added to any.c-bolt-listwith inset turned on.