Fix: Temporarily Disable “Pretty” HTML in Pattern Lab Code Viewer #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
N/A
Summary
Temporarily disables the custom Pattern Lab patch that automatically indents HTML code previews in Pattern Lab + removes extra white space.
Details
Workaround to address PHP CLI memory issues being encountered on Travis that have been causing Pattern Lab to semi-silently fail to finish compiling (resulting in 404 errors on the deployed now.sh site).
How To Test
Confirm that Pattern Lab compiled as expected on the URL we grab from now.sh.
^ CC @danielamorse @adam2661 @remydenton