Figure component refactor #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡ PR built on Travis and deployed a now preview here:
|
added 2 commits
December 26, 2018 21:29
…nto feature/bds-530-figure-component
|
⚡ PR built on Travis and deployed a now preview here:
|
|
⚡ PR built on Travis and deployed a now preview here:
|
|
Hey Dan, I found just 1 issue with the web component, when JS is turned off, it doesn't render any of the
|
|
Never mind that, web component currently has no fallback. Can you confirm what I showed in the screenshot is the current expected behavior? @sghoweri |
danielamorse
approved these changes
Jan 3, 2019
added 2 commits
January 3, 2019 14:57
…nto feature/bds-530-figure-component # Conflicts: # docs-site/src/pages/pattern-lab/_patterns/02-components/figure/00-figure-docs.twig # docs-site/src/pages/pattern-lab/_patterns/02-components/figure/05-figure.twig # packages/components/bolt-figure/package.json
|
⚡ PR built on Travis and deployed a now preview here:
|
added 2 commits
January 4, 2019 10:43
…nto feature/bds-530-figure-component
|
⚡ PR built on Travis and deployed a now preview here:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Summary
Clean up Figure component code and docs. Refactor Figure into web component.
Details
<bolt-figure>is now a web component. If an instance ofbolt-figurealready has a<figure>tag inside it, it will retain a sanitized version of that tag. Otherwise, simply include media and a caption and the web component does the rest (see the docs).How to test