Add the ability to hide or show a prop in the schema table on the Pattern Lab site #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ as a follow-up, I’d recommend we eventually add the ability to hide / show these hidden schema options once some planned JS updates get in (ie. some of the state management updates) so devs can flip a switch to optionally display these internal API options + have the browser remember their preferences (how Pattern Lab’s layout and theme toggles work). |
sghoweri
reviewed
Dec 18, 2018
sghoweri
approved these changes
Dec 18, 2018
danielamorse
approved these changes
Dec 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-847
Summary
Adds the ability to hide or show certain props in the Pattern Lab schema table.
Details
Each prop in the schema table should have the ability to hide or show, in case a developer does not want to expose an internal prop from being consumed by a design system user. Hence the option to hide or show it in the schema table on the Pattern Lab site.
How to test
Try to add
hidden: trueto any prop in a component's schema, make sure it doesn't show up in Pattern Lab anymore.