Add nonce masking operation to PaillierEncryptionKey
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `PaillierEncryptionKey::mask` method, which takes two nonces and produces a masked nonce. It also threads the `MaskedNonce` type through the ZKPs, although currently we still use `.0` to extract the underlying `BigNumber`. This will change once we add some additional functionality for operating on `MaskedNonce`s.
marsella
suggested changes
Jan 23, 2023
|
@marsella Should be ready for another review! |
marsella
suggested changes
Jan 24, 2023
The `nonce` and `mask` were flipped around. To keep the API clean we still keep the argument order but rather change the callers to call `mask` correctly.
marsella
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
PaillierEncryptionKey::maskmethod, which takes two nonces and produces a masked nonce. It also threads theMaskedNoncetype through the ZKPs, although currently we still use.0to extract the underlyingBigNumber. This will change once we add some additional functionality for operating onMaskedNonces (#107).Closes #118.