Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding markdown support to confirmation text #13

Merged
merged 2 commits into from
Apr 7, 2022
Merged

adding markdown support to confirmation text #13

merged 2 commits into from
Apr 7, 2022

Conversation

timclifford
Copy link
Collaborator

image

@timclifford timclifford requested a review from bomoko April 7, 2022 15:23
@timclifford
Copy link
Collaborator Author

this approach is also XSS safe since we do not rely on the dangerouslySetInnerHTML prop, but instead it uses the syntax tree to build out only basic markdown tags. This should prevent script inject attacks

@bomoko bomoko merged commit 34185d0 into feature/confirmation_text_for_custom_tasks Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timclifford @bomoko