Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#200, #203] Sidebar에서 레이블 짤리는 버그 해결 #204

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

junsushin-dev
Copy link
Collaborator

구현의도

  • 레이블이 짤리지 않고 여러 줄에 걸쳐서 보이도록 변경하였습니다.

기능 흐름도, 클래스 다이어그램(선택사항)

사용된 기술

  • 오픈소스 라이브러리
  • 라이브러리를 왜 썼는가?

리뷰요청 & 논의사항 & 궁금한점

  • A 부분은 더 깔끔한 방식이 있을까 궁금하다.
  • B 클래스명은 괜찮은 지 궁금하다.

flex-wrap을 nowrap(default)에서 wrap으로 변경
width property를 96%에서 삭제해서 auto로 변경하여 해결
@junsushin-dev junsushin-dev added the bug Something isn't working label Nov 13, 2020
@junsushin-dev junsushin-dev self-assigned this Nov 13, 2020
Copy link
Collaborator

@dhyun2 dhyun2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 고쳐야하는 버근데 고쳐주셨네요 ㅠㅠ 감사합니다! 😊

Copy link
Member

@passwd10 passwd10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 준수님 😄

@passwd10 passwd10 merged commit b8cf000 into boostcamp-2020:develop Nov 13, 2020
@junsushin-dev junsushin-dev deleted the fix/label-sizing branch January 11, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants