chore: 메타설정 (favicon, title 등)

boostcampwm2023 · Nov 16, 2023 · 4e7eb5d · 4e7eb5d
1 parent c769a8c
commit 4e7eb5d
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 24 deletions.
diff --git a/FE/package.json b/FE/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "fe-boilerplate",
+  "name": "gomterview",
   "version": "1.0.0",
   "description": "",
   "main": "index.js",

diff --git a/FE/public/favicon.ico b/FE/public/favicon.ico
diff --git a/FE/public/index.html b/FE/public/index.html
@@ -1,12 +1,13 @@
 <!doctype html>
-<html lang="ko">
-  <head>
-    <meta charset="UTF-8" />
-    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>FE boilerplate</title>
-  </head>
-  <body>
-    <noscript>You need to enable JavaScript to run this app.</noscript>
-    <div id="root"></div>
-  </body>
+<html lang='ko'>
+<head>
+  <meta charset='UTF-8' />
+  <link href='./favicon.ico' rel='icon'>
+  <meta content='width=device-width, initial-scale=1.0' name='viewport' />
+  <title>곰터뷰</title>
+</head>
+<body>
+<noscript>You need to enable JavaScript to run this app.</noscript>
+<div id='root'></div>
+</body>
 </html>
diff --git a/FE/src/index.tsx b/FE/src/index.tsx
@@ -15,16 +15,21 @@ if (process.env.REACT_APP_GTAG_ID) {
   ReactGA.initialize(process.env.REACT_APP_GTAG_ID);
 }
 
-deferRender()
-  .then(() => {
-    const rootElement = document.getElementById('root');
-    if (rootElement) {
-      const root = ReactDOM.createRoot(rootElement);
-      root.render(<App />);
-    } else {
-      console.error('Root element not found');
-    }
-  })
-  .catch((err) => {
-    console.error('Failed to start mock service worker', err);
-  });
+const rootElement = document.getElementById('root');
+
+const root = ReactDOM.createRoot(rootElement!);
+root.render(<App />);
+
+// deferRender()
+//   .then(() => {
+//     const rootElement = document.getElementById('root');
+//     if (rootElement) {
+//       const root = ReactDOM.createRoot(rootElement);
+//       root.render(<App />);
+//     } else {
+//       console.error('Root element not found');
+//     }
+//   })
+//   .catch((err) => {
+//     console.error('Failed to start mock service worker', err);
+//   });
diff --git a/FE/webpack.config.js b/FE/webpack.config.js
@@ -41,6 +41,7 @@ module.exports = {
     new HtmlWebpackPlugin({
       template: './public/index.html',
       filename: 'index.html',
+      favicon: './public/favicon.ico',
     }),
     new webpack.HotModuleReplacementPlugin(),
     new CopyPlugin({