-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDD-285]: 문제집 삭제 로직 구현 (1h / 1h) #128
Conversation
Deploying with Cloudflare Pages
|
).rejects.toThrow(new WorkbookForbiddenException()); | ||
}); | ||
|
||
it('없는 문제집을 삭제요청하ㅑ면 WorkbookNotFoundException처리한다', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타 발견했습니다!! 수정 부탁드려요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('문제집을 성공적으로 삭제한다', async () => { | ||
//given | ||
await memberRepository.save(memberFixture); | ||
await categoryRepository.save(categoryFixtureWithId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
통합 테스트 시 member와 category를 save하는 것은 공통 로직인거 같은데 beforeEach로 하나의 함수로 리팩터링 하는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Why
How
Result