[NDD-363] 문제집이 하나도 없을 때 생성 유도, QuestionSelectionBox 에서 면접세트 보러가기 페이지 유도(1.5h / 2h) #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5efc9f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd003362.gomterview.pages.dev |
| Branch Preview URL: | https://feature-ndd-363.gomterview.pages.dev |
adultlee
approved these changes
Dec 12, 2023
Yoon-Hae-Min
approved these changes
Dec 12, 2023
Comment on lines
+49
to
+65
| {workbookListData.length ? ( | ||
| workbookListData.map((workbook, index) => ( | ||
| <TabPanelItem | ||
| key={workbook.workbookId} | ||
| tabIndex={index.toString()} | ||
| workbook={workbook} | ||
| isSidebarOpen={ | ||
| isSidebarToggleOn && isDeviceBreakpoint('tablet') | ||
| } | ||
| onSidebarToggleClick={() => | ||
| setIsSidebarToggleOn((prev) => !prev) | ||
| } | ||
| /> | ||
| )) | ||
| ) : ( | ||
| <QuestionTabPanelBlank /> | ||
| )} |
There was a problem hiding this comment.
[p-5] errorboundary suspense empty 세개를 묶은 하나의 선언형 컴포넌트를 만들면 재미있을거 같네요 ㅎㅎ
There was a problem hiding this comment.
좋은데요!??? 근데 이 부분은 요청이 성공했는데 응답 배열이 비어있는 경우도 표현해줘야해서 suspense를 활용하긴 힘들겠네요ㅠㅠ
There was a problem hiding this comment.
[p-5] 나중에 꼭 foundation으로 빼보아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
처음 가입한 유저는 복제된 문제집이 존재하지 않아 아래와 같은 빈 화면을 보여준다는 문제가 있었습니다.
따라서 이를 개선하기 위한 UI를 추가했습니다.
추가로 문제집 목록 페이지가 잘 눈에 들어오지 않는다는 피드백이 있어서, 다이얼로그를 통해 QuestionSelecitonBox에서 문제집 페이지로 이동할 수 있도록 유도했습니다.
How
Result
문제집이 하나도 없을 때
문제집 묶음 페이지 다이얼로그로 유도