Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDD-178]: 회원 이름 반환 시 DTO로 반환하도록 변경 (0.3h / 1h) #63

Merged
merged 4 commits into from
Nov 17, 2023
Merged

[NDD-178]: 회원 이름 반환 시 DTO로 반환하도록 변경 (0.3h / 1h) #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05983dc
feat: 회원 닉네임 반환을 위한 객체 정의
quiet-honey Nov 16, 2023
b3cc6ca
rename: DTO 이름을 memberNicknameResponse로 변경
quiet-honey Nov 16, 2023
f89669d
feat: String을 Dto로 반환하도록 변경 완료
quiet-honey Nov 16, 2023
ff3423d
docs: dto로 반환되도록 변경함에 따른 Swagger 문서화 관련 코드 변경
quiet-honey Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion BE/src/member/controller/member.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { Member } from '../entity/member';
import { createApiResponseOption } from 'src/util/swagger.util';
import { MemberService } from '../service/member.service';
import { validateManipulatedToken } from 'src/util/token.util';
import { MemberNicknameResponse } from '../dto/memberNicknameResponse';

@Controller('/api/member')
@ApiTags('member')
Expand Down Expand Up @@ -45,7 +46,7 @@ export class MemberController {
createApiResponseOption(
200,
`면접 화면에 표출할 이름(회원의 경우 저장된 이름을, 비회원의 경우 '면접자')을 반환한다.`,
String,
MemberNicknameResponse,
),
)
async getNameForInterview(@Req() req: Request) {
Expand Down
11 changes: 11 additions & 0 deletions BE/src/member/dto/memberNicknameResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { ApiProperty } from '@nestjs/swagger';
import { createPropertyOption } from 'src/util/swagger.util';

export class MemberNicknameResponse {
@ApiProperty(createPropertyOption('foobar', '회원의 닉네임', String))
private nickname: string;

constructor(nickname: string) {
this.nickname = nickname;
}
}
5 changes: 4 additions & 1 deletion BE/src/member/service/member.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { Request } from 'express';
import { TokenService } from 'src/token/service/token.service';
import { MemberRepository } from '../repository/member.repository';
import { getTokenValue } from 'src/util/token.util';
import { MemberNicknameResponse } from '../dto/memberNicknameResponse';

@Injectable()
export class MemberService {
Expand All @@ -14,7 +15,9 @@ export class MemberService {
if (!req.cookies['accessToken']) return '면접자';

// TODO: 추후에 랜덤 Prefix 생성할 필요가 있음
return (await this.getMemberByToken(getTokenValue(req))).nickname;
return new MemberNicknameResponse(
(await this.getMemberByToken(getTokenValue(req))).nickname,
);
}

async getMemberByToken(tokenValue: string) {
Expand Down
Loading