Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDD-243] 마이페이지 탭에 질문 선택 박스 연결 (0.5h / 1h) #99

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

milk717
Copy link
Collaborator

@milk717 milk717 commented Nov 23, 2023

NDD-243 Powered by Pull Request Badge

Why

해민님이 QuestionSelectionBox를 잘 만들어주셔서 금방 끝낼 수 있었습니다.

How

  • QuestionSelectionBox를 common 컴포넌트로 이동했습니다.

Result

image

@milk717 milk717 added FE 프론트엔드 코드 변경사항 feature 새로운 기능이 추가 된 경우 labels Nov 23, 2023
@milk717 milk717 self-assigned this Nov 23, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 470797d
Status:⚡️  Build in progress...

View logs

@milk717 milk717 changed the title [NDD-243] 마이페이지 탭에 질문 선택 박스 연결 (0.1h / 1h) [NDD-243] 마이페이지 탭에 질문 선택 박스 연결 (0.5h / 1h) Nov 23, 2023
Copy link
Collaborator

@adultlee adultlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!

@milk717 milk717 merged commit f11158a into dev Nov 23, 2023
1 check was pending
@delete-merged-branch delete-merged-branch bot deleted the feature/NDD-243 branch November 23, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트엔드 코드 변경사항 feature 새로운 기능이 추가 된 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants