Improve global error handler #1394

gonzalojaubert · 2023-04-11T09:28:45Z

Description

Changes

Add ScheduleCommandHandler metadata
Add EventHandler metadata
Add Reducer metadata
Add Projection metadata
Add EventHandler envelope
Add Reducer envelope
Add Projection envelope

Checks

Project Builds
Project passes tests and checks
Updated documentation accordingly

what-the-diff · 2023-04-11T09:29:06Z

PR Summary

Improve GlobalErrorHandler
Enhanced error handling capabilities
Update Error Handlers with New Parameters
Increased context and information available when handling errors
Modify and Add Tests
Ensure new features work as expected and maintain quality
Remove Deprecated ReadModelGlobalError
Clean up codebase by removing unused and deprecated error handler
Rename and Update ScheduleCommandGlobalError
Clarify error handler's purpose and provide more context for scheduled commands errors

ghost · 2023-04-11T09:29:57Z

👇 Click on the image for a new way to code review

Legend

DKarandikar · 2023-06-30T13:50:04Z

Hi @gonzalojaubert, we're just engaging with the global error handler in our Booster deployment and this looks like a useful set of changes. It would be great for us if we could get these changes in, pending approval from the Booster folks

…handler # Conflicts: # common/config/rush/pnpm-lock.yaml # packages/framework-core/src/booster-event-dispatcher.ts # packages/framework-core/src/booster-global-error-dispatcher.ts # packages/framework-integration-tests/integration/provider-unaware/functionality/errors.integration.ts # packages/framework-integration-tests/src/common/app-error-handler.ts # packages/framework-types/src/concepts/global-error-handler-metadata.ts # packages/framework-types/src/errors/snapshot-persist-handler-global-error.ts

…handler # Conflicts: # packages/framework-core/src/booster-global-error-dispatcher.ts # packages/framework-core/src/services/event-store.ts # packages/framework-core/src/services/read-model-store.ts # packages/framework-integration-tests/src/common/app-error-handler.ts # packages/framework-types/src/concepts/global-error-handler-metadata.ts # packages/framework-types/src/errors/index.ts # website/docs/03_features/05_error-handling.md

MarcAstr0 · 2024-08-05T16:21:56Z

/integration sha=959871a03c248e72f83953ae520930aa759fa5cb

github-actions · 2024-08-05T16:22:17Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2024-08-05T17:17:29Z

✅ Integration tests have finished successfully!

packages/framework-core/src/booster-global-error-dispatcher.ts

packages/framework-integration-tests/src/common/app-error-handler.ts

packages/framework-types/src/errors/event-handler-global-error.ts

davidverdu

LGTM. I left some non-blocking comments

gonzalojaubert added 2 commits April 11, 2023 10:22

improve GlobalErrorHandler

de4745d

Add rush change file

c75d0bf

gonzalojaubert marked this pull request as draft April 11, 2023 09:28

Castro and others added 4 commits May 6, 2024 17:06

Post-merge fixes

8756895

Update pnpm-lock.yaml

959871a

MarcAstr0 marked this pull request as ready for review August 5, 2024 16:22

MarcAstr0 requested review from alvaroloes and davidverdu August 5, 2024 16:22