Refactor: reworked core exports #1491
Conversation
|
Oops, looks like you forgot to add a changeset.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here. Remember that you should use the version bump that is appropriate for the change you are making:
If you are unsure about which version bump to use, please ask in the comments and we will help you out. |
javiertoledo
force-pushed
the
refactor/reworked-core-exported-static-methods
branch
from
f2572cf to
18f0435
Compare
|
/integration sha=00adf90abd8b29bb0f3eb46c9462a07ff6e9612a |
|
⌛ Integration tests are running... Check their status here 👈 |
|
✅ Integration tests have finished successfully! |
javiertoledo
force-pushed
the
refactor/reworked-core-exported-static-methods
branch
from
00adf90 to
d2e57fe
Compare
|
/integration sha=d2e57fecc55aaaf0644d6804b485b6b12ef4ed27 |
|
⌛ Integration tests are running... Check their status here 👈 |
|
✅ Integration tests have finished successfully! |
javiertoledo
deleted the
refactor/reworked-core-exported-static-methods
branch
Description
Cleanup of exported methods of the core package to avoid extra levels of indirection. The core index interface has not changed, but I've moved the implementation of the static methods from the
booster.tsfile to theindex.tsto avoid a level of indirection. TheBoosterApptype was made redundant as it was just describing theBoosterclass signature.Changes
index.tsBoosterobject directly without proxying it through theBoosterApptypeBoosterApptype, as theBoosterobject already exports the correct signature. This type was used only to type-check loading user apps from the CLI, and while the type was exported, it was not used in practice. Users use theBoostersingleton exported by the core package instead.Boosterclass, as they were never exported; thus, removing them is not a breaking change.