Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary @cdktf/provider-azurerm dependency from Azure provider package #1554

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

MarcAstr0
Copy link
Collaborator

Description

This PR removes the @cdktf/provider-azurerm from the framework-provider-azure package. This dependency was introduced in commit bc7438a, part of #1552, but this dependency is only required by the framework-provider-azure-infrastructure package. Including this dependency in framework-provider-azure was causing Booster apps to bloat.

Changes

  • Removes @cdktf/provider-azurerm from package.json in framework-provider-azure package.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@MarcAstr0
Copy link
Collaborator Author

/integration sha=07a3e29

Copy link

what-the-diff bot commented Oct 8, 2024

PR Summary

  • Dependency Removal
    Removed an existing dependency called @cdktf/provider-azurerm from the Azure provider package. This removal helps to decrease the complexity and improve the maintainability of the project.

  • Updates to Packages
    Some software packages that our project uses have been updated to the latest version (2.18.3). This ensures that we're using the most updated and secure libraries. These include:

    • @boostercloud/application-tester
    • @boostercloud/eslint-config
    • @boostercloud/framework-core
    • @boostercloud/framework-types
    • @boostercloud/framework-common-helpers
    • @boostercloud/metadata-booster
    • @boostercloud/cli
    • All the relevant framework-provider-* packages
  • Addition of JSON file
    A new JSON file remove_cdktf_dependency_2024-10-08-12-24.json was created. This file documents the specific changes related to the removal of the @cdktf/provider-azurerm dependency providing a historical record. This enhancement supports better tracking and understanding of changes in the project.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

⌛ Integration tests are running...

Check their status here 👈

@MarcAstr0 MarcAstr0 marked this pull request as ready for review October 8, 2024 13:38
@MarcAstr0 MarcAstr0 added the dependencies Pull requests that update a dependency file label Oct 8, 2024
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcAstr0 MarcAstr0 merged commit 1c97d6d into boostercloud:main Oct 8, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Integration tests have finished successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants