Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphql union types for queries #1555

Merged
merged 20 commits into from
Dec 13, 2024
Merged

Graphql union types for queries #1555

merged 20 commits into from
Dec 13, 2024

Conversation

nicolas-scheers-lemon
Copy link
Contributor

@nicolas-scheers-lemon nicolas-scheers-lemon commented Oct 9, 2024 •
edited
Loading

Description

Changes

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@nicolas-scheers-lemon
Copy link
Contributor Author

/integration sha=a76305e

@nicolas-scheers-lemon
Copy link
Contributor Author

/integration sha=ab07fed

@hendrik-depauw-lemon
Copy link
Contributor

Hey @javiertoledo, have you had the time yet to take a look at this PR? Thanks in advance!

@hendrik-depauw-lemon
Copy link
Contributor

Hey @javiertoledo, can I bump this PR? 🙂

davidverdu
davidverdu reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@davidverdu davidverdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolas-scheers-lemon Great work! I left two comments. Please let me know when they are addressed, so that we can approve it

@davidverdu
Copy link
Collaborator

nonetheless @nicolas-scheers-lemon , you also need to add the changeset file. Please run rush change and commit the changeset file

@nicolas-scheers-lemon
Copy link
Contributor Author

@davidverdu I addressed your comments and added the changeset file

@davidverdu
Copy link
Collaborator

Hi @nicolas-scheers-lemon @hendrik-depauw-lemon the PR is approved. However, you need to solve the conflicts, for example, by rebasing. Could you do that?

@nicolas-scheers-lemon
Copy link
Contributor Author

@davidverdu I solved the conflict

@davidverdu
Copy link
Collaborator

/integration sha=cca4d47

@github-actions GitHub Actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions GitHub Actions
Copy link
Contributor

✅ Integration tests have finished successfully!

@davidverdu davidverdu merged commit 7c82d3a into boostercloud:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcAstr0 MarcAstr0 MarcAstr0 approved these changes

@davidverdu davidverdu davidverdu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-scheers-lemon @hendrik-depauw-lemon @davidverdu @MarcAstr0 @msnm